Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make providing withdrawal credentials required #153

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Make providing withdrawal credentials required #153

merged 1 commit into from
Jan 24, 2023

Conversation

wackerow
Copy link
Contributor

@wackerow wackerow commented Jan 19, 2023 •
edited
Loading

Description

  • Removes the "Advanced" option, making providing a withdrawal address required
  • Updates tooltip helper text and mentions of "optional"

Screenshot

image

Related issue

@wackerow wackerow changed the title make providing withdrawal creds required Make providing withdrawal credentials required Jan 19, 2023
@alexpeterson91
Copy link
Contributor

I fully agree with this. I actually implemented this same thing (in a slightly less efficient way) on my fork for Gnosis chain about a year ago. Since withdrawal addresses were required from genesis of the gnosis beacon-chain when generating more than one key at a time so it was necessary for Gnosis chain since it existed and it has for Ethereum even longer just not since genesis. Definitely happy to see someone else thinking the same and submitting this PR. 👍

@wackerow
Copy link
Contributor Author

Also noting that the staking-deposit-cli that Wagyu wraps currently has a draft PR up to make the withdrawal address required: ethereum/staking-deposit-cli#315

remyroy
remyroy approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@remyroy remyroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems good.

@remyroy remyroy merged commit 12b5645 into stake-house:main Jan 24, 2023
@wackerow wackerow deleted the require-withdrawal-credentials branch January 25, 2023 01:38
@barnabasbusa barnabasbusa mentioned this pull request Feb 2, 2023
Draft
This was referenced Feb 4, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyroy remyroy remyroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Withdrawal address should be required
3 participants
@wackerow @alexpeterson91 @remyroy