Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checks before ending match and penalty shootout #35

Merged
merged 5 commits into from
Jul 6, 2024

Conversation

0xRampey
Copy link
Member

@0xRampey 0xRampey commented Jul 6, 2024

This PR:

  • Throws error if ending the match b/w teams with the same goal score
  • Throws an error if trying to start a Penalty shootout b/w teams with different goal scores

Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would instead always compute the final score including penalties first.

Since overall being draw is what should throw error, not the initial score beings drawn

@aashutoshrathi aashutoshrathi merged commit 134b47f into main Jul 6, 2024
1 check passed
@eshaan7 eshaan7 deleted the feat/checks branch October 30, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants