Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspaces to OpenAPI spec #634

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Add workspaces to OpenAPI spec #634

merged 9 commits into from
Jan 20, 2025

Conversation

alex-mcgovern
Copy link
Contributor

@alex-mcgovern alex-mcgovern commented Jan 17, 2025

Exposes the workspaces API to the OpenAPI spec.
Also moves the dashboard router under the /api/v1 router, and uses the root FastAPI app to build the OpenAPI spec, which should include all new endpoints.
Finally, tidies up the operation IDs for the dashboard endpoints as they were getting ridiculously long.

@JAORMX
Copy link
Contributor

JAORMX commented Jan 17, 2025

Why is this not automated?

JAORMX
JAORMX previously approved these changes Jan 17, 2025
@alex-mcgovern
Copy link
Contributor Author

Why is this not automated?

Do you mean the generation, or including routers for generation?

@JAORMX
Copy link
Contributor

JAORMX commented Jan 17, 2025

The openapi.json generation, that's right

@alex-mcgovern
Copy link
Contributor Author

There's some discussion around cleanest way to do this happening on discord

@alex-mcgovern alex-mcgovern marked this pull request as ready for review January 17, 2025 15:39
@lukehinds lukehinds merged commit cdbac96 into main Jan 20, 2025
3 checks passed
@lukehinds lukehinds deleted the workspaces-to-open-api-spec branch January 20, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants