Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds note for copilot docs #82

Merged
merged 6 commits into from
Feb 18, 2025
Merged

fix: adds note for copilot docs #82

merged 6 commits into from
Feb 18, 2025

Conversation

ChrisJBurns
Copy link
Contributor

If you have a file open, when running codegate version, you get a response based on the file and not the codegate version itself. I've added a note to inform users that they close all files before running the command. Outside of this PR, we may want to decide if this is desired functionality by Copilot or Codegate and if the version should be returned regardless if a file is currently open or not.

If you have a file open, when running `codegate version`, you get a response based on the file and not the codegate version itself. I've added a note to inform users that they close all files before running the command.
Outside of this PR, we may want to decide if this is desired functionality by Copilot or Codegate and if the version should be returned regardless if a file is currently open or not.
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codegate-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 6:54pm

@danbarr
Copy link
Collaborator

danbarr commented Feb 17, 2025

This isn't the intended behavior, and may be a bug. Having a file in context didn't previously break codegate commands.

@ChrisJBurns
Copy link
Contributor Author

@danbarr Yeah I was probably a bit too quick with the PR, I found out shortly after that it was a bug. Is it worth adding a link to the bug issue number in this note, or shall we just close this PR in hopes that the bug gets fixed before many first time users of codegate realise?

Copy link
Collaborator

@danbarr danbarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and add the note since Copilot's one of our most popular integrations. I suggested some updated wording. It would also be good to add this note to the Copilot Quickstart guide, in between here:

Enter `codegate version` in the Copilot chat to confirm that CodeGate is
intercepting Copilot traffic. CodeGate responds with its version number.
## Explore CodeGate's key features

Enter `codegate version` in the Copilot chat to confirm that CodeGate is
intercepting Copilot traffic. CodeGate responds with its version number.

:::note

There is a [known issue](https://github.com/stacklok/codegate/issues/1061) with
`codegate` commands in Copilot chat if you have a file included in the context.
Close all open files or use the eye icon in the chat input to disable the
current file context, otherwise Copilot responds based on the file you have open
instead of returning the command result.

:::

## Explore CodeGate's key features

Co-authored-by: Dan Barr <[email protected]>
Co-authored-by: Dan Barr <[email protected]>
@ChrisJBurns
Copy link
Contributor Author

@danbarr Have committed your suggestions and added that extra note! 👍

@ChrisJBurns
Copy link
Contributor Author

@danbarr happy to merge when you are

@danbarr
Copy link
Collaborator

danbarr commented Feb 18, 2025

Oh I assumed you had permisisons to 😄

Merging now, thanks for pointing out this issue!

@danbarr danbarr merged commit 38f8f04 into main Feb 18, 2025
6 checks passed
@danbarr danbarr deleted the copilot-note branch February 18, 2025 19:30
@ChrisJBurns
Copy link
Contributor Author

@danbarr Oh, yes I did, I just didn't know if it was ok to merge incase there were things that had to happen first on public facing docs haha! So wanted to check with you first before I did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants