Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Docker #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jivagoalves
Copy link

No description provided.

@jivagoalves
Copy link
Author

Can you guys help me out with the build failure? I'm confused. Am I supposed to set GITHUB_TOKEN somewhere to make specs pass on CI?

@juanpaucar
Copy link
Contributor

@jivagoalves indeed you need to set up 5 environment vars to run the tests, but on the travis file you will see them as env: global and each var after secure... i'm not sure why it's not reading the travis file when using docker containers
https://travis-ci.org/stackbuilders/octohat/jobs/51400229 you can see "Setting environment variables from .travis.yml" but is not on the build from this PR... i guess there must be something special between docker containers and env vars set on the travis file

@jivagoalves
Copy link
Author

@juanpaucar thanks for your help! I understand we need to set the env vars locally in order to run the specs. However, I believe travis will do that for us in the build as you said. I don't think travis is running any docker container because they are using ubuntu as worker while the docker image I'm using is based from debian. I'll take another look later when I get a chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants