Skip to content

docs: Document how to turn off quorum hostname verification #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

sbernauer
Copy link
Member

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer sbernauer requested review from lfrancke and a team May 23, 2024 13:54
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the content, thank you!
I just believe this should go into some kind of how to or troubleshooting section.

@fhennig

@sbernauer
Copy link
Member Author

I just believe this should go into some kind of how to or troubleshooting section.

100% agreed. I didn't find where to locate it best :/

@sbernauer
Copy link
Member Author

It's especially hard as I don't have an error message or similar. Guess I need to search the customer issue

@sbernauer
Copy link
Member Author

I added a troubleshooting guide, happy about @fhennig comments

@sbernauer sbernauer requested a review from fhennig May 23, 2024 14:27
@lfrancke
Copy link
Member

Thank you. I think this can wait for Felix to come back from vacation. Let's park it until next week.

ssl.quorum.hostnameVerification: "false"
----

WARNING: This imposes a security risk, so we don't disable the check by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very empty statement, what risk does it expose you to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of

WARNING: This imposes a security risk, so we don't disable the check by default. Any possessor of a certificate signed by the ca (even for a totally different host) can pretend to be a Zookeeper server to a Zookeeper server.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nightkr can you please have another look?

Copy link
Member

@nightkr nightkr Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that covers the issue better, yes, and would be better if we do merge this.

Preliminarily I'd rather just solve #760 than document the workaround, unless we're running out of time for the release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only raised this PR because it was on the tasklist. Happy to move it to Track for now.
Updated the section anyway

@sbernauer sbernauer self-assigned this May 27, 2024
@fhennig
Copy link
Contributor

fhennig commented May 27, 2024

Good stuff! I like it. I think it's good where it is placed. Just resolve the discussion about the warning, I'd also like it to be more specific.

@sbernauer
Copy link
Member Author

Moving to Track because

Preliminarily I'd rather just solve #760 than document the workaround, unless we're running out of time for the release.

@nightkr
Copy link
Member

nightkr commented Jun 19, 2024

So for 24.7 our only green version will be 3.9.2 where this issue is already "solved" by FIPS mode being enabled by default (see #760 (comment)). I would propose closing this PR, or changing it to only mention enabling FIPS mode on 3.8.4.

@nightkr nightkr closed this Jun 26, 2024
@nightkr nightkr deleted the docs/quorum-hostname-verification branch June 26, 2024 10:16
@sbernauer
Copy link
Member Author

Works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants