Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Bump OpenTelemetry related dependencies #977

Merged
merged 14 commits into from
Apr 2, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Mar 7, 2025

Part of stackabletech/issues#639

This PR bumps OpenTelemetry related dependencies and adjusts the code accordingly. It also removes the initialize_logging helper function due it being no longer maintainable because of incompatibilities in the underlying libraries.

Additionally, the CLI interface is adjusted to include more granular arguments (and env variables) which enable different outputs and exporters for telemetry data.

These changes were tested using the dummy-webhook and the observability stack.

@Techassi Techassi self-assigned this Mar 7, 2025
This commit also adjust the code based on the many breaking changes
between the old and new versions of the crates. The public API is
not affected by these changes.
Due to the dependency bumps in the previous commit, this function
can no longer be maintained due to the underlying libraries being
incompatible. It is recommended to use stackable_telemetry as the
replacement.
Due to initialize_logging being removed and being replaced by
stackable_telemetry, the CLI interface needs to be adjusted as well.
The old --tracing-target argument is removed in favour of more
granular arguments to enable different outputs and exporters.
@Techassi Techassi force-pushed the chore/opentelemetry-bumps branch from 1edd66b to 413833c Compare March 17, 2025 12:41
@Techassi Techassi changed the title chore(stackable-telemetry): Bump OpenTelemetry related dependencies chore(stackable-telemetry)!: Bump OpenTelemetry related dependencies Mar 17, 2025
@Techassi Techassi changed the title chore(stackable-telemetry)!: Bump OpenTelemetry related dependencies chore!: Bump OpenTelemetry related dependencies Apr 1, 2025
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review April 2, 2025 10:29
NickLarsenNZ
NickLarsenNZ previously approved these changes Apr 2, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi enabled auto-merge April 2, 2025 10:42
@Techassi Techassi added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit ed43376 Apr 2, 2025
8 checks passed
@Techassi Techassi deleted the chore/opentelemetry-bumps branch April 2, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants