Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inject vector aggregator address as env into vector config #600

Merged
merged 27 commits into from
Apr 9, 2025

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Apr 1, 2025

Description

  • Start watching ConfigMaps that are referenced in AirflowCluster spec and have not been created by the operator to restart Pods on changes to these ConfigMaps.
  • Inject vector aggregator address into the vector config using the env var VECTOR_AGGREGATOR_ADDRESS.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@labrenbe labrenbe changed the title fix: Start watching configmaps that are referenced in superset spec fix: Start watching configmaps that are referenced in airflow spec Apr 1, 2025
@labrenbe labrenbe self-assigned this Apr 7, 2025
@labrenbe labrenbe changed the title fix: Start watching configmaps that are referenced in airflow spec WIP: fix: Start watching configmaps that are referenced in airflow spec Apr 7, 2025
@labrenbe labrenbe changed the title WIP: fix: Start watching configmaps that are referenced in airflow spec fix: Start watching configmaps that are referenced in airflow spec Apr 8, 2025
@labrenbe labrenbe changed the title fix: Start watching configmaps that are referenced in airflow spec feat: Inject vector aggregator address as env into vector config Apr 8, 2025
@labrenbe labrenbe marked this pull request as ready for review April 9, 2025 11:19
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine, just a couple of suggestions.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing around borrows

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions around borrowing

@NickLarsenNZ NickLarsenNZ enabled auto-merge April 9, 2025 15:40
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit dff7fb2 Apr 9, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/reconcile-on-configmap branch April 9, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants