-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(publish gitlab pages): Update publish comment on gitlab #7853
Conversation
Thanks for the PR. Is this also true for GitLab's hosted offering, or only for on-premise installations? |
I discouvered it on gitlab.com (SaaS) |
Thanks! So if it's such a central thing, I think it would be a better idea to list the steps that you listed in your blog post directly on our publishing guide, so we can keep the AX better – less indirection. If and only if this is okay for you. |
Yes, sure! I just did this so that the site doesn't get too crowded with information. Should I make an extra page or is it enough if I just write it down under the CI codeblock? |
Just under the code block is fine. I think we can limit it to something like (extracted from your article):
And we should link to the release notes, as you did in your article. |
No, please just use verbatim text. It's not a recommendation, but the expected outcome (= users will 99% want a proper URL, and not a random identifier), so it should be part of the normal flow. |
@squidfunk it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some minor changes related to formatting
I solved the styling issues |
Perfect, thanks for your work! |
You're welcome. Happy new year! |
Happy new year to you too! |
I have noticed that since a few GitLab releases, unique domains are used by default for GitLab Pages deployments, for example
https://website-5c034c.gitlab.io/
instead ofniclasheinz.gitlab.io/website
. I have written a small blog post that helps users to use the desired domain.