shark: make examples compile in different package #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include import statements and fix a few APIs that had drifted, and an invalid variable name. I've tested this locally against LeakCanary v2.14 and it compiles now. Towards square#2610
|
|
|
Thanks. Is any extra work necessary to make this visible on the website?
Does it rollout automatically?
…On Tue, 21 May 2024 at 09:21, py - Pierre Yves Ricau < ***@***.***> wrote:
Merged #2668 <#2668> into main.
—
Reply to this email directly, view it on GitHub
<#2668 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZYOMQ4VYRMDCFPZGAEULZDKAQVAVCNFSM6AAAAABHMH3H5OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHA3TCOJZGUYTCMA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include import statements and fix a few APIs that had drifted, and an invalid variable name.
With this change, you should be able to copy/paste the examples and run them, even if you code is not in the 'shark' package.
I've tested this locally against LeakCanary v2.14 and it compiles now.
It would be nice long-term to have these examples compiling in CI so they stay up to date, but I'm not going to attempt that now.
Towards #2610