Skip to content

Replace use of utcnow() with now() for Python 3.13 compatibility, Fixes #1643 #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenstroeger
Copy link

@jenstroeger jenstroeger commented Apr 10, 2025

Description

Fixes: #1643

Existing tests should cover this change.

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

@CaselIT
Copy link
Member

CaselIT commented Apr 10, 2025

It seems that the tests are mocking something that needs updating

@jenstroeger
Copy link
Author

Ah ok, I’ll take a look. I didn’t find a CONTRIBUTING file so this initial change was a bit of a shot in the dark 🤓

@CaselIT
Copy link
Member

CaselIT commented Apr 10, 2025

no problem, it's what the ci is for!

@jenstroeger jenstroeger force-pushed the replace-utcnow-for-py313 branch from c0372b1 to 1ddb3ca Compare April 13, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace utcnow() which is deprecated on Python 3.13
2 participants