Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add remote-files capability to remote-client plugin #23381

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

hlouzada
Copy link
Contributor

@hlouzada hlouzada commented Dec 30, 2024

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)

Add remote files system API using fsspec for the remote-client plugin.

Use a mixture of rest/websocket to comunicate with spyder-remote-services and
provide a filesystem-like API to control remote file system.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @hlouzada

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "d7e4319b5"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "master"
  commit:   "d7e4319b5"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@pep8speaks
Copy link

pep8speaks commented Dec 30, 2024

Hello @hlouzada! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 115:80: E501 line too long (80 > 79 characters)

Line 2:80: E501 line too long (87 > 79 characters)

Line 47:80: E501 line too long (100 > 79 characters)
Line 68:80: E501 line too long (86 > 79 characters)
Line 85:1: E302 expected 2 blank lines, found 1
Line 104:1: E303 too many blank lines (3)
Line 132:80: E501 line too long (88 > 79 characters)
Line 134:80: E501 line too long (86 > 79 characters)
Line 150:80: E501 line too long (81 > 79 characters)

Line 28:80: E501 line too long (83 > 79 characters)
Line 36:80: E501 line too long (103 > 79 characters)
Line 191:80: E501 line too long (82 > 79 characters)
Line 192:70: E128 continuation line under-indented for visual indent
Line 193:70: E128 continuation line under-indented for visual indent
Line 193:80: E501 line too long (90 > 79 characters)
Line 386:80: E501 line too long (91 > 79 characters)
Line 419:65: E252 missing whitespace around parameter equals
Line 419:66: E252 missing whitespace around parameter equals

Line 87:70: W291 trailing whitespace

Line 101:1: W293 blank line contains whitespace
Line 105:1: W293 blank line contains whitespace
Line 108:1: W293 blank line contains whitespace
Line 111:80: E501 line too long (83 > 79 characters)
Line 128:80: E501 line too long (90 > 79 characters)

Line 48:80: E501 line too long (85 > 79 characters)
Line 101:80: E501 line too long (96 > 79 characters)
Line 102:80: E501 line too long (104 > 79 characters)

Line 25:80: E501 line too long (99 > 79 characters)
Line 544:1: W293 blank line contains whitespace
Line 549:1: W293 blank line contains whitespace
Line 552:1: W293 blank line contains whitespace
Line 586:29: E251 unexpected spaces around keyword / parameter equals
Line 586:31: E251 unexpected spaces around keyword / parameter equals

Line 13:80: E501 line too long (100 > 79 characters)
Line 19:1: E302 expected 2 blank lines, found 1
Line 31:80: E501 line too long (82 > 79 characters)
Line 33:1: E302 expected 2 blank lines, found 1
Line 48:1: E302 expected 2 blank lines, found 1
Line 52:80: E501 line too long (100 > 79 characters)
Line 71:80: E501 line too long (93 > 79 characters)
Line 72:80: E501 line too long (82 > 79 characters)
Line 72:83: W291 trailing whitespace
Line 73:80: E501 line too long (99 > 79 characters)
Line 74:80: E501 line too long (95 > 79 characters)
Line 75:80: E501 line too long (91 > 79 characters)
Line 89:80: E501 line too long (88 > 79 characters)
Line 90:80: E501 line too long (90 > 79 characters)
Line 91:1: W293 blank line contains whitespace
Line 99:80: E501 line too long (119 > 79 characters)
Line 100:1: W293 blank line contains whitespace
Line 108:1: W293 blank line contains whitespace
Line 137:80: E501 line too long (82 > 79 characters)
Line 141:80: E501 line too long (89 > 79 characters)
Line 142:1: W293 blank line contains whitespace
Line 152:1: W293 blank line contains whitespace
Line 155:1: W293 blank line contains whitespace
Line 157:1: W293 blank line contains whitespace
Line 186:1: W293 blank line contains whitespace
Line 188:36: E251 unexpected spaces around keyword / parameter equals
Line 188:38: E251 unexpected spaces around keyword / parameter equals
Line 189:1: W293 blank line contains whitespace
Line 191:80: E501 line too long (87 > 79 characters)
Line 225:80: E501 line too long (91 > 79 characters)
Line 225:80: E741 ambiguous variable name 'l'
Line 243:1: E302 expected 2 blank lines, found 1
Line 272:48: E252 missing whitespace around parameter equals
Line 272:49: E252 missing whitespace around parameter equals
Line 273:80: E501 line too long (128 > 79 characters)
Line 277:80: E501 line too long (90 > 79 characters)
Line 281:80: E501 line too long (92 > 79 characters)
Line 285:80: E501 line too long (92 > 79 characters)
Line 287:1: W293 blank line contains whitespace
Line 289:80: E501 line too long (91 > 79 characters)
Line 291:1: W293 blank line contains whitespace
Line 292:59: E252 missing whitespace around parameter equals
Line 292:60: E252 missing whitespace around parameter equals
Line 292:80: E252 missing whitespace around parameter equals
Line 292:80: E501 line too long (87 > 79 characters)
Line 292:81: E252 missing whitespace around parameter equals
Line 294:80: E501 line too long (91 > 79 characters)
Line 295:80: E501 line too long (93 > 79 characters)
Line 297:1: W293 blank line contains whitespace
Line 299:80: E501 line too long (94 > 79 characters)
Line 301:1: W293 blank line contains whitespace
Line 302:56: E252 missing whitespace around parameter equals
Line 302:57: E252 missing whitespace around parameter equals
Line 303:80: E501 line too long (80 > 79 characters)
Line 304:39: E128 continuation line under-indented for visual indent
Line 304:80: E501 line too long (98 > 79 characters)
Line 306:1: W293 blank line contains whitespace
Line 309:80: E501 line too long (85 > 79 characters)
Line 314:80: E501 line too long (105 > 79 characters)
Line 319:80: E501 line too long (85 > 79 characters)
Line 322:53: E252 missing whitespace around parameter equals
Line 322:54: E252 missing whitespace around parameter equals
Line 324:80: E501 line too long (93 > 79 characters)
Line 327:80: E501 line too long (85 > 79 characters)
Line 328:80: E501 line too long (94 > 79 characters)

Line 43:80: E501 line too long (93 > 79 characters)
Line 397:1: W293 blank line contains whitespace

Line 31:80: E501 line too long (82 > 79 characters)
Line 57:80: E501 line too long (90 > 79 characters)
Line 62:1: W293 blank line contains whitespace
Line 103:1: W293 blank line contains whitespace
Line 122:80: E501 line too long (97 > 79 characters)
Line 123:80: E501 line too long (98 > 79 characters)
Line 124:1: W293 blank line contains whitespace
Line 136:80: E501 line too long (82 > 79 characters)

Comment last updated at 2025-01-18 23:23:22 UTC

@hlouzada hlouzada changed the title Add remote-files capability to remote-client plugin [WIP] PR: Add remote-files capability to remote-client plugin Dec 30, 2024
@hlouzada hlouzada marked this pull request as ready for review January 18, 2025 13:58
@hlouzada hlouzada changed the title [WIP] PR: Add remote-files capability to remote-client plugin PR: Add remote-files capability to remote-client plugin Jan 18, 2025
…xternal-deps/spyder-remote-services

subrepo:
  subdir:   "external-deps/spyder-remote-services"
  merged:   "e2f920d11"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-remote-services"
  branch:   "feat/remote-file-service"
  commit:   "e2f920d11"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
…xternal-deps/spyder-remote-services

subrepo:
  subdir:   "external-deps/spyder-remote-services"
  merged:   "83bfb48fd"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-remote-services"
  branch:   "feat/remote-file-service"
  commit:   "83bfb48fd"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants