-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SC-XXX: Improved speed of docker image building #449
base: master
Are you sure you want to change the base?
Conversation
- Introduced `docker bake` as main build mechanism with fallback to `docker build` if bake is not available - Adjusted build process by utilising multistage builds and paralleling builds - Optimised cache usage by separating/moving parameters that are changed often (e.g. build hash, stamp) - Fixed bug with `docker/sdk export` when export options was ignored when `-v` option was used at the same time - Added labels for all images containing project revision, project name and SDK revision - Adjusted maintenance mode to be controlled by environment variable: SPRYKER_MAINTENANCE_MODE_ENABLED=1 docker/sdk run
…update instead of create/delete
Great to see this being worked on @sprymiker. For comparison: |
…llowing parallel pushes of application images
- Removed intermediate dump-autoload as it probably takes more time than benifits for the following build
…n 0.7.1 - Upgraded syntax docker version - Removed parallelisation for fallback build (without buildx)
…ing dependencies.
…g them in cli image
Optimized pipeline and jenkins images by removing unnecessary binaries (e.g. PGSQL client if database is MYSQL)
Any chances for this PR to be merged eventually @zyuzka @alexanderM91 |
Hi @oleg-glushak, |
Description
Inspired by https://github.com/spryker/docker-sdk/tree/onsteroids. Thank you, @oleg-glushak!
Difference:
docker build bake
covers this OOTBP.S. Image size concern was not fully considered. Additional activities measurements are needed, including changes in spryker/docker-php as a separate topic.
Related resources
Change log
Improved speed of docker image building
docker bake
as the primary build mechanism with a fallback todocker build
if bake is not availabledocker/sdk export
when export options were ignored when-v
option was used at the same timeSPRYKER_MAINTENANCE_MODE_ENABLED=1 docker/sdk run
Checklist