-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for partitioned cookies #42316
Conversation
Thanks @nosan. I think we should also update |
3eca7a4
to
8a04295
Compare
Thanks for the feedback @philwebb. I did update my PR but unfortunately, I have not found a straightforward way to update The only way as I understand is: map.from(cookie::getPartitioned)
.to(partitioned -> config.setAttribute(PARTITIONED_ATTRIBUTE_NAME, Boolean.toString(partitioned))); |
I think this is the only way to support partitioned cookies, see Tomcat for reference: |
@bclozel |
@nosan you can raise this as a Tomcat issue if you think this is a bug. |
@bclozel
so, this line which I added in this PR should work: map.from(cookie::getPartitioned)
.to(partitioned -> config.setAttribute(PARTITIONED_ATTRIBUTE_NAME, Boolean.toString(partitioned))); |
That was as well my assessment in the first place. |
Thanks @nosan ! |
gh-42307