Ensure last-wins profile order is respected for AWS Parameter Store and Secrets Manager #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd Secrets Manager Fixes spring-cloud#2385
driseley
force-pushed
the
fix-profile-order
branch
from
ec72902 to
6a1a53e
Compare
|
Fixed checkstyle issue and force pushed |
|
@spencergibb - is it possible to get the build for this PR rerun? |
|
Thanks for the PR @driseley. The 4.0.x branch is no longer supported so we will not be cherry picking the PR back to that branch because there will not be any more open source releases of that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2385
Note, for Secrets Manager this fix breaks existing tests, which I have corrected. I don't think the existing tests assert the correct expected profile order, so these have been updated to reflect the changed logic. However I don't know if this counts as a breaking change?
Also, I would be very grateful, if this is accepted, if it could be backported to the 4.0.x branch as this is the version we are currently using and where it affects us.