-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some issue & label endpoints #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note on the assignee
/assignees
. I don't feel strongly about it but am wary of breaking changes. PTAL @GriffinCodes
Great idea, made the change and it behaves correctly. Still learning all the features Jackson :) |
Apologies for the force push, I removed the commit that changed the version in the pom.xml |
@@ -0,0 +1,48 @@ | |||
/*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This serializer seems like it could be replaced by Jackson annotations too - thoughts?
@@ -0,0 +1,48 @@ | |||
/*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This serializer seems like it could be replaced by Jackson annotations too - thoughts?
Hi @GriffinCodes. We apologise for taking so long to get eyes on this PR, we haven't been able to maintain this library to the standard we would have liked to but this will be changing in the new year. If you could please get this rebased and we'll be prioritising all open PRs ready for review. Thanks! Ellie |
Hello, As this PR is now stale and we've not had any new activity on it, we've decided to close it so we can keep track of active/more recent changes. We will leave the branch untouched in case you would like to reopen and rebase. Thanks! Ellie |
Just some work I did for my discord bot
Some questions:
@JsonSerializer(using = <Type>Serializer.class)
, or is there another way I should be doing it?Optional
vs@Nullable
seems to be arbitrary; is there a pattern I'm not seeing?Feedback welcome
Closes #62