Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to get a user installation for the authenticated app #191

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

annelled
Copy link
Contributor

What
Add support to get a user installation for the authenticated app.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.26%. Comparing base (a8848f5) to head (2aa4e8c).

Files Patch % Lines
...va/com/spotify/github/v3/clients/GitHubClient.java 0.00% 1 Missing ⚠️
...java/com/spotify/github/v3/clients/UserClient.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #191      +/-   ##
============================================
+ Coverage     76.17%   76.26%   +0.08%     
- Complexity      315      317       +2     
============================================
  Files            44       44              
  Lines          1062     1066       +4     
  Branches         44       44              
============================================
+ Hits            809      813       +4     
  Misses          227      227              
  Partials         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dennisgranath
dennisgranath previously approved these changes Jun 14, 2024
Copy link
Contributor

@dennisgranath dennisgranath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see that coverage complains about tests. Should be relatively easy to add that similarly to the getInstallation endpoint.

@ebk45 ebk45 merged commit 392b505 into master Jun 14, 2024
4 of 5 checks passed
@ebk45 ebk45 deleted the annelled/add-user-installation-get-methods branch June 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants