Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-4475: Adds chrome flags to provider #66

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

sangn-splunk
Copy link
Collaborator

@sangn-splunk sangn-splunk commented Nov 8, 2024

Resolves SYN-4475


Before the change?

  • Browser configs do not support chrome_flags.

After the change?

  • Browser configs should support chrome_flags.

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

$ TF_ACC=1 TF_LOG=INFO go test ./synthetics/... -run TestAccCreateUpdateBrowserCheckV2
ok      github.com/splunk/terraform-provider-synthetics/synthetics      (cached)

Does this introduce a breaking change?

  • Yes
  • No

@sangn-splunk sangn-splunk marked this pull request as draft November 8, 2024 21:27
@sangn-splunk sangn-splunk self-assigned this Nov 8, 2024
@sangn-splunk sangn-splunk marked this pull request as ready for review November 13, 2024 21:48
@sangn-splunk sangn-splunk merged commit c3b4941 into splunk:main Nov 13, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants