Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYN-4842: browser tests excluded files #33

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

SYN-4842: browser tests excluded files #33

wants to merge 1 commit into from
+18 −3

Conversation

mtichy-splunk
Copy link
Collaborator

@mtichy-splunk mtichy-splunk commented Mar 5, 2025 •
edited
Loading

Support for Browser tests Excluded files

Before the change?

  • No support for advancedSettings.excludedFiles

After the change?

  • Support configuration of advancedSettings.excludedFiles

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

Does this introduce a breaking change?

  • Yes
  • No

@mtichy-splunk mtichy-splunk self-assigned this Mar 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅

@mtichy-splunk
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@mtichy-splunk
Copy link
Collaborator Author

I have read the Code of Conduct and I hereby accept the Terms

srv-gh-tools added a commit to splunk/cla-agreement that referenced this pull request Mar 5, 2025
@srv-gh-tools
@mtichy-splunk has signed the CLA in splunk/syntheticsclient#33
9be0dac
etipton-splunk
etipton-splunk approved these changes Mar 13, 2025
View reviewed changes
Copy link

@etipton-splunk etipton-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward-enough ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pajk Pajk Pajk approved these changes

@etipton-splunk etipton-splunk etipton-splunk approved these changes

@sangn-splunk sangn-splunk Awaiting requested review from sangn-splunk

Assignees

@mtichy-splunk mtichy-splunk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtichy-splunk @Pajk @etipton-splunk