Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchCommand._execute_v2()
writes records as soon as a result from the chunk is processed, rather than capturing a generator of all the records from the chunk, and then writing.SearchCommand._records_protocol_v2
SearchCommand._records_protocol_v2()
to leverageSearchCommand._read_csv_records()
, though the reading may need to be processed in a higher layer.SearchCommand._execute_v2()
, since it is only used bygenerating_command.py
, as such we may want a common abstract interface for all commands using the v2 protocol.