Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVPL-12129_investigation #551

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DVPL-12129_investigation #551

wants to merge 1 commit into from

Conversation

l00py
Copy link
Contributor

@l00py l00py commented Oct 28, 2023

  • Related issue SDK 1.7.4 does not stream all events in one chunk in a distributed search #541
  • Findings
    • Behavior change since 1.6.15 from Fix chunk synchronization #301
    • SearchCommand._execute_v2() writes records as soon as a result from the chunk is processed, rather than capturing a generator of all the records from the chunk, and then writing.
  • Reverting a few logics
    • Reintroduced SearchCommand._records_protocol_v2
  • Remaining action items
    • May need to refactor SearchCommand._records_protocol_v2() to leverage SearchCommand._read_csv_records(), though the reading may need to be processed in a higher layer.
    • May need to refactor SearchCommand._execute_v2(), since it is only used by generating_command.py, as such we may want a common abstract interface for all commands using the v2 protocol.
    • Regression testings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant