Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analytics_enhancement #3291

Merged
merged 24 commits into from
Feb 10, 2025
Merged

analytics_enhancement #3291

merged 24 commits into from
Feb 10, 2025

Conversation

tccontre
Copy link
Contributor

@tccontre tccontre commented Jan 23, 2025

renamed

  • known_services_killed_by_ransomware.yml -> detections/endpoint/windows_security_and_backup_services_stop.yml
  • suspicious_process_file_path.yml -> detections/endpoint/windows_suspicious_process_file_path.yml

updated

  • linux_auditd_find_credentials_from_password_managers.yml
  • permission_modification_using_takeown_app.yml
  • suspicious_driver_loaded_path.yml
  • windows_driver_load_non_standard_path.yml

new macro

  • macros/normalized_service_binary_field.yml

new detections

  • windows_process_execution_in_temp_dir.yml

What does this PR have in it? Screenshots are worth 1000 words 😄

Screenshot 2025-01-22 at 15 12 59

TTP to Anomaly

  • linux_auditd_file_permissions_modification_via_chattr.yml
  • linux_auditd_hidden_files_and_directories_creation.yml
  • linux_auditd_service_started.yml
  • linux_auditd_stop_services.yml

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the datestamp in the lookup CSV filename, and the reference to it in the YAML needs to be updated.

@tccontre tccontre added the WIP DO NOT MERGE Work in Progress label Jan 23, 2025
@tccontre tccontre removed the WIP DO NOT MERGE Work in Progress label Feb 3, 2025
@nasbench nasbench changed the base branch from develop to mitrests February 3, 2025 17:46
@nasbench nasbench changed the base branch from mitrests to develop February 3, 2025 17:47
Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One rename needs another look, its currently deleting the existing detection and creating a new one

@ljstella ljstella self-requested a review February 10, 2025 22:18
Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patel-bhavin patel-bhavin merged commit 56c4d19 into develop Feb 10, 2025
4 checks passed
@patel-bhavin patel-bhavin deleted the analytics_enhancement branch February 10, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants