Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid extra fields in YMLs #208

Open
wants to merge 108 commits into
base: release_v4.2.0
Choose a base branch
from

Commits on May 15, 2024

  1. Code which still needs testing

    to enable ACS deployment.
    reduce non-blocking warnings
    thrown by appinspect api by
    updating some automatically
    generated app files.
    pyth0n1c committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6f982e7 View commit details
    Browse the repository at this point in the history
  2. add proper access for sc_admin

    to default.meta
    pyth0n1c committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1f7afd7 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Configuration menu
    Copy the full SHA
    9caf4f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    1c2ef2f View commit details
    Browse the repository at this point in the history
  2. Re-enable acs deployment

    in contentctl.py.
    Print out what is returned from
    ACS, even on success.
    pyth0n1c committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    d5b08d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Add an extra, missing field to the lookup.py model called max_matches…

    … that was accidentally dropped. set extra='forbid' for SecurityContentObject
    pyth0n1c committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    60b6e1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd33140 View commit details
    Browse the repository at this point in the history
  3. update template to remove risk_score since it is a comptued_field and…

    … should not be in the yml
    pyth0n1c committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    e4f7dcc View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    a453237 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    25601d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    22aa2e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    bbcacda View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    a1c0915 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Relax requirement on search

    string from drilldown
    pyth0n1c authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0b48ce4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81d01da View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    b3e7330 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    8a9d8ec View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    1e51d6d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    cbb56db View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    72e3354 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    34d0ff6 View commit details
    Browse the repository at this point in the history
  2. Add the possibility

    to automatically create
    drilldowns. We will
    likely remove this, but let's
    keep it now for purposes
    of discussion.
    pyth0n1c committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9ba9300 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c5f9f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. due to a parsing issue with events created

    in the risk index, create the detection type
    as a list of 1 element, the type of the detection
    pyth0n1c authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7d9d128 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge pull request #179 from splunk/release_v4.2.0

    contentctl v4.4.0
    pyth0n1c authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a17256b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c21622 View commit details
    Browse the repository at this point in the history
  3. Added some documentation and

    updated the jinja2 template.
    escapeNewlines() was ONLY
    being applied to the
    detection.description before,
    but it MUST be applied to
    the explanation as well. This
    bug was confirmed by generating
    some conf files with description
    and/or explanations, with spaces,
    defined.
    Now, whichever value is used to
    populate that field is properly
    escaped.
    pyth0n1c committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    eedd07e View commit details
    Browse the repository at this point in the history
  4. Merge pull request #296 from splunk/ryanplasma_add_explanation

    Ryanplasma add explanation
    pyth0n1c authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a199c72 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    506bbaf View commit details
    Browse the repository at this point in the history
  6. Merge pull request #293 from splunk/add_detection_type_list

    Add type_list to annotations
    pyth0n1c authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    dde564b View commit details
    Browse the repository at this point in the history
  7. Remove erroneous spaces from datasources used by contentctl new --typ…

    …e detection. Also remove the list of datasource from new_content_questions and instead use the datasource defined in enums and convert them to a list
    pyth0n1c committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a609c03 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #297 from splunk/contentctl_data_source_from_enum

    Fix datasource in contentctl new
    pyth0n1c authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5488ca6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9a83a3c View commit details
    Browse the repository at this point in the history
  10. remove deffault values for earliesT_offset and latest_offset.

    These values must be supplied explicitly.
    pyth0n1c committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    20e8840 View commit details
    Browse the repository at this point in the history
  11. experimenting with updating

    the drilldowns and generating
    defaults
    pyth0n1c committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a849e34 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7bde9d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Switch drilldowns to dump in json format so

    we can support and arbitrary number of them
    pyth0n1c committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c0cff81 View commit details
    Browse the repository at this point in the history
  2. Fix serialization issue with drilldowns.

    Format of multiple drilldowns in
    savedsearches.conf is now correct.
    We are still populating the default
    drilldowns, this feature will
    eventually be removed.
    pyth0n1c committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5ca8ade View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f30e62 View commit details
    Browse the repository at this point in the history
  4. remove some debugging

    pyth0n1c committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3280fbf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5226073 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    098905a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. fixes to ensure that every search that

    needs one should have the appropriate
    default drilldown.
    pyth0n1c committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    db7de0b View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Raise exception on parse of unittest from yml. Do this rather than tr…

    …ying to convert it into an integrationtest or manualtest.
    pyth0n1c committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3a4be5d View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. In rare cases, if there is a new piece of

    content that has already been committed
    to the current branch AND there are local,
    uncommitted changes to that content,
    GitService will pick up BOTH the fact that
    this is new content AND the fact that it has been
    modified. This will result in double-testing
    the content. This commit removes that as
    a possibility by adding content to be tested
    to a SET instead of appending it to a LIST,
    which couild have included duplicates.
    pyth0n1c committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    c627d2e View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    1f15302 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Update xmltodict requirement from ^0.13.0 to >=0.13,<0.15

    Updates the requirements on [xmltodict](https://github.com/martinblech/xmltodict) to permit the latest version.
    - [Changelog](https://github.com/martinblech/xmltodict/blob/master/CHANGELOG.md)
    - [Commits](martinblech/xmltodict@v0.13.0...v0.14.0)
    
    ---
    updated-dependencies:
    - dependency-name: xmltodict
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    32690df View commit details
    Browse the repository at this point in the history
  2. commit simple changes so that

    we can get this feature working
    now.  Eventually the more
    robust changes will be merged
    from a separate branch
    pyth0n1c committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b12383e View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Improve logic for regex and macro

    detection. Throw an error when four
    or more ```` appear in a row in the
    search field, which is invalid SPL.
    pyth0n1c committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d79a0a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. add helper func: get_all_indexes

    modify: configure_hec to use get_all_indexes during HEC creation
    ax-hsmith committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2123454 View commit details
    Browse the repository at this point in the history
  2. increment version number

    ax-hsmith committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8575d9f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a470b8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3db70d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge pull request #305 from splunk/simple_allow_missing_detections

    Optionally suppress missing detections during metadata validation
    pyth0n1c authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3d33130 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e8e85d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db6763a View commit details
    Browse the repository at this point in the history
  4. Merge pull request #304 from splunk/dependabot/pip/xmltodict-gte-0.13…

    …-and-lt-0.15
    
    Update xmltodict requirement from ^0.13.0 to >=0.13,<0.15
    pyth0n1c authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2cc708b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8f73477 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    31b4b21 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #300 from splunk/raise_exception_on_malformatted_t…

    …ests
    
    Exception on malformatted unit tests in YMLs
    pyth0n1c authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    02eb5d7 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #308 from splunk/cmcginley/mathieugonzales_replace…

    …_deprecated_pydantic_validators
    
    Refactoring for formatting and some logical error correction
    pyth0n1c authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d3e063a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1550aff View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    80aa067 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #298 from splunk/mathieugonzales_replace_deprecate…

    …d_pydantic_validators
    
    Mathieugonzales: replace deprecated pydantic validators
    
    I am giving my approval after Casey's feedback was merged in from the branch containing a set of fixes.
    pyth0n1c authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c558216 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a4f4222 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    fca535b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f2caab0 View commit details
    Browse the repository at this point in the history
  15. Merge pull request #256 from splunk/add_drilldown_support

    Drilldown Support
    
    Merging to enable testing before the security_content PR containing all drilldowns is merged.
    pyth0n1c authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f7a939b View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    fe17a1e View commit details
    Browse the repository at this point in the history
  17. Merge pull request #307 from ax-hsmith/fix/tests-with-custom-indexes

    Allow testing with the default or custom_index
    pyth0n1c authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6052ef0 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    bf72575 View commit details
    Browse the repository at this point in the history
  2. Throw much better and descriptive exception when triyng to replay to …

    …a custom_index that does not exist on the target server. list out the attempted index and all indexes on the server for documentation purposes.
    pyth0n1c committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    50704d2 View commit details
    Browse the repository at this point in the history
  3. don't bump the version number

    for contentctl
    pyth0n1c committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    adf0f90 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #309 from splunk/all_more_custom_indexes

    Add more custom indexes
    
    ESCU smoketests are failing because the Drilldowns PR has not been merged yet. This is expected.
    pyth0n1c authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cfda377 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9c2bdff View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    23f3742 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. add a cli flag

    patel-bhavin committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    adbbcb5 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. eric feedback

    patel-bhavin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    98808d5 View commit details
    Browse the repository at this point in the history
  2. still optional

    patel-bhavin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d12a173 View commit details
    Browse the repository at this point in the history
  3. default to devleop

    patel-bhavin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f7204a1 View commit details
    Browse the repository at this point in the history
  4. updating config

    patel-bhavin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    cc84524 View commit details
    Browse the repository at this point in the history
  5. udpating toml

    patel-bhavin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3c884d9 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #311 from splunk/release_notes_udpate

    add --compare_against flag to release_notes action
    pyth0n1c authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d4d7d9d View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. remove "cloud" from the security_domain

    enum
    pyth0n1c committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0dad956 View commit details
    Browse the repository at this point in the history
  2. Fix path to fetch a saved

    search by name. Without
    fixing this path, integration
    testing fails to find the search
    and errors out.
    pyth0n1c committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6bcb875 View commit details
    Browse the repository at this point in the history
  3. Fix path that was updated incorrectly. This path is used to find a sa…

    …ved search for scheduling to run during integtration testing. This bad path causes every integration test to fail.
    pyth0n1c committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b580278 View commit details
    Browse the repository at this point in the history
  4. forgot to save before

    committing. see
    previous commit message.
    pyth0n1c committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c9dfa84 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge pull request #316 from splunk/fix_savedsearches_path

    Fix savedsearches path issue
    pyth0n1c authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f9bcd7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98f9921 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge pull request #314 from splunk/fix_security_domain

    remove "cloud" from the security_domain enum
    pyth0n1c authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    35d8b82 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    825d854 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Update pyproject.toml

    just bumping version for release
    pyth0n1c authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    81fa46e View commit details
    Browse the repository at this point in the history
  2. Update pyproject.toml

    pyth0n1c authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7f5319e View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    89b8ad3 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    34ae585 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd77dc6 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #146 from splunk/enable_acs_deploy

    Enable acs deploy + appinspect warnings
    pyth0n1c authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    59a3d1c View commit details
    Browse the repository at this point in the history
  4. Update pyproject.toml

    bump version in prep for release
    pyth0n1c authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    81db497 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    45b3a87 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #324 from splunk/data_sources_clarification

    Ensure we print the right field for data_source
    pyth0n1c authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3c733f1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    af0ff41 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    bbe5da8 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Typing

    ljstella committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4d9a831 View commit details
    Browse the repository at this point in the history
  2. Version bump

    ljstella committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3c9395c View commit details
    Browse the repository at this point in the history
  3. Merge pull request #301 from splunk/test_on_app_change

    Testing on Datasource changes
    pyth0n1c authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b8b5c2d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b4a9217 View commit details
    Browse the repository at this point in the history
  5. Move Baseline datamodel from YML field

    to computed_field
    pyth0n1c committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ef7784d View commit details
    Browse the repository at this point in the history
  6. make datamodel a computed

    field for investigation
    pyth0n1c committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a27f790 View commit details
    Browse the repository at this point in the history