Clean up expr analysis immediate accesses #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatesn
requested changes
Jan 20, 2025
| /// For all subexpressions in an expression, find the fields that are accessed directly from the | ||
| /// scope, but not any fields in those fields | ||
| /// e.g. scope = {a: {b: .., c: ..}, d: ..}, expr = ident().a.b + ident().d accesses {a,d} (not b). | ||
| pub(crate) struct ImmediateIdentityAccessesAnalysis<'a> { |
There was a problem hiding this comment.
If we're cleaning up, can we start the convention of exporting a single function with the same name as the module, then keeping all structs internal?
You may have to define a result type struct for complex result.
There was a problem hiding this comment.
You should move the comment to the public function
# Conflicts: # vortex-expr/src/transform/partition.rs
gatesn
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.