Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node trait as reusable visitor #1918

Closed
wants to merge 9 commits into from
Closed

Conversation

joseph-isaacs
Copy link
Member

@joseph-isaacs joseph-isaacs commented Jan 13, 2025

This is an idea of how to reuse the visitor for other tree structures, we need to find a place to pub the node trait, other than in vortex-expr.

see vortex-expr/src/transform for more complex examples.

This needs a code structure change.

@joseph-isaacs joseph-isaacs requested a review from gatesn January 13, 2025 17:04
@joseph-isaacs joseph-isaacs changed the title [wip] Node trait as reusable visitor Node trait as reusable visitor Jan 15, 2025
Copy link
Contributor

@gatesn gatesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these children functions are quite right, allocating and returning vecs all over the place.

I'll have a think

@gatesn
Copy link
Contributor

gatesn commented Mar 10, 2025

Going to kill this as stale

@gatesn gatesn closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants