feat: vortex-tui #1911
feat: vortex-tui #1911
Conversation
a10y
force-pushed
the
aduffy/vx-cli
branch
2 times, most recently
from
b985a11 to
324a3f5
Compare
vortex-cli/Cargo.toml
Outdated
| [dependencies] | ||
| bytes = { workspace = true } | ||
| clap = { version = "4", features = ["derive"] } | ||
| crossterm = "0.28" |
There was a problem hiding this comment.
Should we move these into root Cargo.toml and use {workspace = true}?
There was a problem hiding this comment.
Yea I was on the fence about this one. The "rusty" thing to do for a binary crate inside of a workspace is seems to be put all deps that are specific to that bin in the local Cargo.toml
E.g. datafusion-cli: https://github.com/apache/datafusion/blob/main/datafusion-cli/Cargo.toml
uv seems to use workspace deps though: https://github.com/astral-sh/uv/blob/main/crates/uv-cli/Cargo.toml
Can move things to workspace
There was a problem hiding this comment.
Oh I see, yeah that may make sense given they end up being locked differently right?
| /// A pointer into the `Layout` hierarchy that can be advanced. | ||
| /// | ||
| /// The pointer wraps an InitialRead. | ||
| pub struct LayoutCursor { |
There was a problem hiding this comment.
Is this somewhat similar to ArrayVisitor?
There was a problem hiding this comment.
Somewhat? It's specifically for layout hierarchy, and just gives us an owned pointer that we can mutate to move up/down the tree
As we change/break format makes it easier to keep this tool up to date. Also helpful for debugging/exploring format.
I've also added a
vxalias so we can immediately access it from cargo, e.g.