Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/application): Delete Application component loses state while refreshing application. #10003

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siddhu-opsmx
Copy link
Collaborator

Whenever application has servergroups, then Application cannot be Deleted and Following message shown from deck "You cannot delete this application because it has server groups."
Issue is when we land on to config page directly deck able to show delete option without checking for server groups (happens in deck Ui too when we load config page directly as shown in below recordings).

Delete Application section before fix:-

DeleteApplication_BeforeFix.mp4

Delete Application section after fix:-

DeleteAplication_AfterFix.mp4

@siddhu-opsmx
Copy link
Collaborator Author

@mattgogerly could you please review the PR

@mattgogerly
Copy link
Member

I'm not sure this is the right fix. This change is passing config.application.serverGroups.data.length as a separate prop, but DeleteApplicationSection is already taking config.application as a prop, so this shouldn't be necessary.

serverGroups.data is updated as part of the refresh cycle (the orange spinner next to the app name).

Can you check in AngularJSAdapter if the props are being updated when the application is refreshed?

@siddhu-opsmx
Copy link
Collaborator Author

@mattgogerly ,Sure, I'll check this and let you know once found something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants