fix(aws): CleanupAlarmsAgent cycle to catch exceptions #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christosarvanitis
requested review from
jeyrschabu and
ajordens
as code owners
dbyron-sf
reviewed
Jan 17, 2025
| @@ -37,7 +37,7 @@ import java.util.regex.Pattern | |||
|
|
|||
| @Slf4j | |||
| class CleanupAlarmsAgent implements RunnableAgent, CustomScheduledAgent { | |||
| public static final long POLL_INTERVAL_MILLIS = TimeUnit.HOURS.toMillis(24) | |||
| public static final long POLL_INTERVAL_MILLIS = TimeUnit.MINUTES.toMillis(3) | |||
There was a problem hiding this comment.
Bad commit on my end. Will revert this
dbyron-sf
reviewed
Jan 17, 2025
| } | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Is there a catch block to add "higher up" (where the run method is called) that would (also) help? Like, what if there exceptions in other agents?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bad account or any exception currently stops the CleanupAlarmsAgent.
Catching the exception and logging it since the purpose of this agent is to cleanup the stale cloudwatch alarms from the aws/ecs accounts in Spinnaker and not to verify if the accounts are valid or not.