fix(ecs): Alarms with custom dimensions should be processed #6324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarulg
approved these changes
Dec 26, 2024
|
LGTM! Thank you for adding tests 🥳 |
link108
approved these changes
Jan 3, 2025
jasonmcintosh
approved these changes
Jan 3, 2025
|
@Mergifyio backport release-1.36.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
(cherry picked from commit 3e932e4)
mergify bot
added a commit
that referenced
this pull request
Jan 3, 2025
…6325) (cherry picked from commit 3e932e4) Co-authored-by: Christos Arvanitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it is preferred/recommended to add dimensions for the Cloudwatch alarms related to the ECS Cluster Name and service name this is not enforced. In some occasions a user can create custom alarms with custom dimensions for filtering that make sense for their operations.
This PR fixes an issue where the ECS Cluster name is not part of the Cloudwatch metric and hence the id doesnt include the ECS Cluster name (because its empty).