Slits async #383
Open
Slits async #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canismarko
added
qa
- Added a plan to set up the slit precision. - The ophyd-async Positioner now uses precision to tell when it's done - Fixed some signal data types for the blade slits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ophyd-async devices for the blade slits (e.g. independent top/bottom jaws), and aperture slits (e.g. high-heat-load slits at 25-ID-A).
The aperture slits are straightforward because they are JBOM (just a bunch of motors). The blade slits use the EPICS optics module, and there is not a PV that reports when the motors are done for each axis (e.g. horizontal center moves both the inboard and outboard blades). This means the positioner must rely on the readback value matching the setpoint to know when it is done. By default, our slits have the precision set to something way higher than what the motors can accomplish. This PR also includes a plan to set up a set of slits with the correct precision so that scanning is possible.
Both kinds of slits deliberately do not include a way to move the individual axes (real motors in the case of aperture slits and individual blades in the case of blade slits). The real motors will still be available as motors if they need to be scanned.
Things to do before merging:
write docs