Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab to run browser for viewing area detector frames #380

Merged
merged 13 commits into from
Feb 28, 2025

Conversation

canismarko
Copy link
Contributor

@canismarko canismarko commented Feb 16, 2025

Things to do before merging:

  • add tests
  • write docs
  • update iconfig_testing.toml
  • flake8, black, and isort

@canismarko canismarko linked an issue Feb 16, 2025 that may be closed by this pull request
@canismarko
Copy link
Contributor Author

Need to add a check to ensure that the first data array dimension matches the length of the time signal.

@canismarko canismarko requested a review from yannachen February 20, 2025 16:51
@canismarko canismarko added enhancement New feature or request Firefly Issues related to the Firefly GUI system run browser Related to the display used for browsing scans in the database labels Feb 20, 2025
Copy link
Collaborator

@yannachen yannachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really understanding the framset_view part. I will test it in the real detector data.

@canismarko
Copy link
Contributor Author

Not really understanding the framset_view part. I will test it in the real detector data.

Originally, all the tabs were just part of one big class (RunBrowserDisplay). This got harder and harder to maintain as we added more tabs.

To fix this, I took each tab and made it it's own class. If you open up run_browser.ui and look at what's inside of one of the tabs, you'll find that it's just an empty widget. Then there's a LineplotView class for the 1D line plot tab, and an associated lineplot_view.ui file. The LineplotView class is in charge of displaying the 1D line plot and managing the widgets for picking a signal to plot, reference corrections, calculating the derivative, etc.

FramesetView and frameset_view.ui are for managing the "Frames" tab, which displays area detector frames.

@yannachen
Copy link
Collaborator

Here is the test using real Ge 8 element images:

  1. It is difficult to choose a right ROI uisng mouse. Is it possilbe to input ROI center values to move the ROI square?
  2. The data demension is 327, 8, 4096. Once uncheck 8, it should be the data of one element. Whiling choosing "Energy" as Time Signal, line plot should be the result of 1 element. But no line plot appeared below the image.

@canismarko canismarko merged commit 34bb033 into main Feb 28, 2025
1 check passed
@canismarko canismarko deleted the run_browser_ad branch February 28, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Firefly Issues related to the Firefly GUI system run browser Related to the display used for browsing scans in the database
Projects
None yet
2 participants