Plan window improvement #353
Conversation
…windows without changeable regions
| @@ -43,7 +46,11 @@ def setup_ui(self): | |||
| self.start_line_edit.textChanged.connect(self.update_step_size) | |||
| self.stop_line_edit.textChanged.connect(self.update_step_size) | |||
|
|
|||
| def update_step_size(self, num_points=None): | |||
| def set_num_points(self, num_points): | |||
| self.num_points = max(2, int(num_points)) # Ensure num_points is >= 2 | |||
There was a problem hiding this comment.
If I type "1" in scan_pts_spin_box, this line will actually use 2 internally. What does the spinbox show in that scenario? Does it still show "1" or does it correctly update to "2"?
There was a problem hiding this comment.
It might be easier to make num_points be a property that reads from the spin box and converts to an integer instead of having to keep track of this state in two places.
|
|
||
| def customize_ui(self): | ||
| self.ui.run_button.clicked.connect(self.queue_plan) | ||
| if hasattr(self.ui, "spinBox_repeat_scan_num"): |
There was a problem hiding this comment.
I think this belongs in the individual child classes instead of the parent classes. Having a parent class make decisions based on things that might be done by the child classes can cause problems.
For example, what if the child class wants to use this spin box differently, or call it something else, or it's not actually a Qt Signal? The child class has no way to do this without breaking the inheritance chain for this method.
Modified ui for plan windows, and made one more parent class that applied for plan windows not having changeable regions, so to reduce redundant codes
Things to do before merging:
There is one test I added in the test_count_window
test_time_calculator, I don't know why it couldn't pass; I copied it from test_line_scan_plan, which passed; I could not figure out why this did not work.