Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for XIA PFCU filters #203

Merged
merged 24 commits into from
Apr 28, 2024
Merged

Support for XIA PFCU filters #203

merged 24 commits into from
Apr 28, 2024

Conversation

canismarko
Copy link
Contributor

canismarko and others added 22 commits April 14, 2024 15:50
@canismarko
Added a device for PFCU-based filters.
d3ad10f
@canismarko
Allow some PFCU filter channels to be turned into shutters.
fa70fff
@canismarko
The PFCU4Shutter device can now be opened and closed.
6c37016
@yannachen
Fixed wrong prefix for PFCU4 shutter filter.
58693e5
@canismarko
Added a function to load the XIA PFCU4 filter banks.
cdc1fb6
@yannachen
Used the PVPositionerSoftDone for the PFCU filters.
46dac9b
@canismarko
Fixed broken xia PFCU4 shutter tests.
95dea0f
@canismarko
Added a firefly window for showing filters.
ff3e244
@yannachen
Improved the UI for the filters in Firefly.
d408fa4
@canismarko
The XIA PFCU shutter device now uses the entire filter bank configura…
2e8aa8f 
…tion if available (faster shutter speed).
@yannachen
Made the graphic for the filters window look continuous (removed padd…
4127327 
…ing).
@yannachen
Fixed polarity of XIA PFCU-based shutter.
ebf031f
@canismarko
Fixed PFCU filter tests.
3e567c0
@canismarko
The Firefly status window now dynamically creates shutter widgets.
99c814c
@yannachen
Added a get() method to the Xia Shutter device.
1903866
@canismarko
The XIA PFCUShutter now has a readback signal with the shutter's curr…
ebfcd79 
…ent state.
@canismarko
Added is_open and is_closed signals to the XIA PFCUShutter device.
956aa5c
@yannachen
Partially implemented the shutter widgets in the status window.
4abc942
@canismarko
Made the XIA PFCUShutter into a proper Ophyd positioner.
4a96cc6
@yannachen
The XIA PFCUFilterBank now uses PFCUFastShutters by default.
328afa3
@canismarko
Fixed XIA tests, removed old code, and linted.
ed7254a
@yannachen
Changed the XIA PFCUShutter states enum when the shutter is half-open.
c40ef97
@canismarko canismarko added the enhancement New feature or request label Apr 28, 2024
@canismarko canismarko added this to the Commissioning milestone Apr 28, 2024
@canismarko canismarko merged commit 547eb49 into main Apr 28, 2024
1 check passed
@canismarko canismarko deleted the filters branch April 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Extra device support
Status: Done
Milestone
Commissioning
Development

Successfully merging this pull request may close these issues.
2 participants
@canismarko @yannachen