-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved XDI support #194
Merged
Merged
Improved XDI support #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
canismarko
commented
Apr 13, 2024
•
edited
Loading
edited
- Fixes Convert the XDI file callback to a stand-alone function (or use the XDI suitcase) #83
- Fixes Add mono d-spacing to the XDI file writer #2
i.e. it can be subscribed to the RunEngine, etc. since multiple calls to XDIWriter.start will just create a new file name each time.
…r now makes parent directories.
descriptor document. Also, only the primary data stream is used for writing XDI files.
Note: it uses the energy_positioner's ``d_spacing`` component. This doesn't necessariy save the real mono; future work will need to be done to make sure the energy device's ``d_spacing`` component is actually the d-spacing of the mono.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.