Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the homebrew async caget with the one from aioca. #173

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ dependencies:
# - pygithub

- pip:
- aioca
- apsbss
- time-machine
- autoapi
Expand Down
4 changes: 1 addition & 3 deletions src/firefly/area_detector_viewer.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@


class AreaDetectorViewerDisplay(display.FireflyDisplay):
caqtdm_ui_file: str = (
"/APSshare/epics/synApps_6_2_1/support/areaDetector-R3-12-1/ADAravis/aravisApp/op/ui/autoconvert/ADAravis.ui"
)
caqtdm_ui_file: str = "/APSshare/epics/synApps_6_2_1/support/areaDetector-R3-12-1/ADAravis/aravisApp/op/ui/autoconvert/ADAravis.ui"
image_is_new: bool = True

def customize_device(self):
Expand Down
8 changes: 2 additions & 6 deletions src/firefly/ion_chamber.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,8 @@ class IonChamberDisplay(display.FireflyDisplay):
"""A GUI window for changing settings in an ion chamber."""

caqtdm_scaler_ui_file: str = "/net/s25data/xorApps/ui/scaler32_full_offset.ui"
caqtdm_mcs_ui_file: str = (
"/APSshare/epics/synApps_6_2_1/support/mca-R7-9//mcaApp/op/ui/autoconvert/SIS38XX.ui"
)
caqtdm_preamp_ui_file: str = (
"/net/s25data/xorApps/epics/synApps_6_2_1/support/ip-GIT/ipApp/op/ui/autoconvert/SR570.ui"
)
caqtdm_mcs_ui_file: str = "/APSshare/epics/synApps_6_2_1/support/mca-R7-9//mcaApp/op/ui/autoconvert/SIS38XX.ui"
caqtdm_preamp_ui_file: str = "/net/s25data/xorApps/epics/synApps_6_2_1/support/ip-GIT/ipApp/op/ui/autoconvert/SR570.ui"

def customize_device(self):
self._device = registry.find(self.macros()["IC"])
Expand Down
4 changes: 1 addition & 3 deletions src/firefly/voltmeters.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
class VoltmetersDisplay(display.FireflyDisplay):
_ion_chamber_displays = []
caqtdm_scaler_ui_file: str = "/net/s25data/xorApps/ui/scaler32_full_offset.ui"
caqtdm_mcs_ui_file: str = (
"/APSshare/epics/synApps_6_2_1/support/mca-R7-9//mcaApp/op/ui/autoconvert/SIS38XX.ui"
)
caqtdm_mcs_ui_file: str = "/APSshare/epics/synApps_6_2_1/support/mca-R7-9//mcaApp/op/ui/autoconvert/SIS38XX.ui"

def __init__(
self,
Expand Down
3 changes: 2 additions & 1 deletion src/haven/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ class SignalNotFound(KeyError):
...


class EmptySignalName(ValueError): ...
class EmptySignalName(ValueError):
...


class InvalidTransformation(TypeError):
Expand Down
15 changes: 10 additions & 5 deletions src/haven/instrument/area_detector.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,16 @@ class AsyncCamMixin(OphydObject):
acquire = ADCpt(SignalWithRBV, "Acquire")


class SimDetectorCam_V34(CamMixin_V34, SimDetectorCam): ...
class SimDetectorCam_V34(CamMixin_V34, SimDetectorCam):
...


class EigerCam(AsyncCamMixin, EigerDetectorCam): ...
class EigerCam(AsyncCamMixin, EigerDetectorCam):
...


class LambdaCam(AsyncCamMixin, Lambda750kCam): ...
class LambdaCam(AsyncCamMixin, Lambda750kCam):
...


class WriteModes(IntEnum):
Expand Down Expand Up @@ -130,10 +133,12 @@ class StatsMixin:
]


class StatsPlugin_V31(StatsMixin, OphydStatsPlugin_V31): ...
class StatsPlugin_V31(StatsMixin, OphydStatsPlugin_V31):
...


class StatsPlugin_V34(StatsMixin, OphydStatsPlugin_V34): ...
class StatsPlugin_V34(StatsMixin, OphydStatsPlugin_V34):
...


class SimDetector(SingleTrigger_V34, DetectorBase):
Expand Down
60 changes: 0 additions & 60 deletions src/haven/instrument/epics.py

This file was deleted.

2 changes: 1 addition & 1 deletion src/haven/instrument/ion_chamber.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import numpy as np
import pint
from aioca import caget
from apstools.devices import SRS570_PreAmplifier
from ophyd import Component as Cpt
from ophyd import Device, EpicsSignal, EpicsSignalRO
Expand All @@ -26,7 +27,6 @@
from .. import exceptions
from .._iconfig import load_config
from .device import aload_devices, await_for_connection, make_device
from .epics import caget
from .instrument_registry import registry
from .labjack import AnalogInput
from .scaler_triggered import ScalerSignalRO, ScalerTriggered
Expand Down
2 changes: 1 addition & 1 deletion src/haven/instrument/motor.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
import logging
from typing import Optional

from aioca import caget
from ophyd import Component as Cpt
from ophyd import EpicsMotor, EpicsSignal, EpicsSignalRO

from .._iconfig import load_config
from .device import aload_devices, make_device
from .epics import caget
from .instrument_registry import registry

log = logging.getLogger(__name__)
Expand Down
6 changes: 4 additions & 2 deletions src/haven/instrument/scaler_triggered.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,12 @@ def _trigger_scaler(self, *args, **kwargs):
return new_status


class ScalerSignal(ScalerTriggered, EpicsSignal): ...
class ScalerSignal(ScalerTriggered, EpicsSignal):
...


class ScalerSignalRO(ScalerTriggered, EpicsSignalRO): ...
class ScalerSignalRO(ScalerTriggered, EpicsSignalRO):
...


# -----------------------------------------------------------------------------
Expand Down
Loading