Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using config.get() to get robot #170

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Using config.get() to get robot #170

merged 8 commits into from
Feb 26, 2024

Conversation

yannachen
Copy link
Collaborator

No description provided.

@canismarko canismarko self-requested a review February 23, 2024 16:25
@yannachen
Copy link
Collaborator Author

While assert sim_registry.find(label="robots", findall = False) == None, I found ComponentNotFound was, the I updated to the current version.

canismarko
canismarko requested changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@canismarko canismarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to outdent those two lines. Otherwise, providing a config argument will still not create any devices.

@canismarko
Copy link
Contributor

All set as far as I'm concerned. Merge when ready. Thanks @yannachen!

@canismarko canismarko added the bug Something isn't working label Feb 24, 2024
@yannachen yannachen merged commit 4b05d5c into spc-group:main Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canismarko canismarko canismarko approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannachen @canismarko