Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3737: Handle micrometeorite flashes (v2) #349

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drlaw1558
Copy link
Contributor

@drlaw1558 drlaw1558 commented Mar 7, 2025

This PR addresses JP-3737 by adding an additional check in the jump step to look for micrometeorite flashes, which manifest as bursts of jumps across a large fraction of the detector. This replaces prior PR #308, updating it to work with the refactored jump step. Corresponding jwst PR is spacetelescope/jwst#9253

Kept in draft form for now pending potential future modifications.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (068afd9) to head (166293e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/jump/jump.py 8.69% 21 Missing ⚠️
src/stcal/jump/jump_class.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   85.96%   85.78%   -0.18%     
==========================================
  Files          61       61              
  Lines       10333    10358      +25     
==========================================
+ Hits         8883     8886       +3     
- Misses       1450     1472      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant