Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin numpy <2 #1275

Merged
merged 2 commits into from
Jun 17, 2024
Merged

pin numpy <2 #1275

merged 2 commits into from
Jun 17, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 17, 2024

Numpy 2.0 was released. This is causing many tests to fail due to incompatible depedencies:
https://github.com/spacetelescope/romancal/actions/runs/9539663192/job/26290288431

These include:

This PR pins numpy to <2.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 17, 2024
@braingram braingram marked this pull request as ready for review June 17, 2024 14:00
@braingram braingram requested a review from a team as a code owner June 17, 2024 14:00
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.24%. Comparing base (4580f59) to head (77eb980).
Report is 196 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1275   +/-   ##
=======================================
  Coverage   79.24%   79.24%           
=======================================
  Files         117      117           
  Lines        8075     8075           
=======================================
  Hits         6399     6399           
  Misses       1676     1676           
Flag Coverage Δ *Carryforward flag
nightly 62.78% <ø> (ø) Carriedforward from 4580f59

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -10,6 +10,8 @@ Documentation
general
-------

- pin numpy to <2 [#1275]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't generally add dependency versions to the changes file.

@braingram braingram merged commit 79d3a30 into spacetelescope:main Jun 17, 2024
30 checks passed
@braingram braingram deleted the pin_numpy branch June 17, 2024 15:20
braingram added a commit to braingram/romancal that referenced this pull request Jun 18, 2024
This reverts commit 79d3a30, reversing
changes made to 4580f59.
braingram added a commit to braingram/romancal that referenced this pull request Jun 18, 2024
This reverts commit 79d3a30, reversing
changes made to 4580f59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants