Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3667: Add safeguards for NSClean on background/imprint members #8809

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Sep 19, 2024

Resolves JP-3667

Follow up to #8786 to fix some unexpected interactions between badpix_selfcal and nsclean, causing a failure in the badpix_selfcal regression tests. If badpix_selfcal is run, the background members are datamodels instead of filenames.

I also noticed in testing this that setting the output file for nsclean on the background/imprint members caused them to be saved by default, so I added a check for that as well.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API?
    • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke requested a review from a team as a code owner September 19, 2024 20:20
@melanieclarke melanieclarke requested review from hayescr and a team and removed request for a team September 19, 2024 20:20
@melanieclarke melanieclarke added this to the Build 11.1 milestone Sep 19, 2024
@melanieclarke melanieclarke added the nsclean NIRSpec NSClean algorithm label Sep 19, 2024
@melanieclarke
Copy link
Collaborator Author

Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending regression tests showing no unexpected failures

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.76%. Comparing base (da9691d) to head (9c68fc3).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
jwst/pipeline/calwebb_spec2.py 6.25% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8809   +/-   ##
=======================================
  Coverage   61.75%   61.76%           
=======================================
  Files         377      377           
  Lines       38750    38785   +35     
=======================================
+ Hits        23931    23955   +24     
- Misses      14819    14830   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hayescr hayescr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, sorry I missed this on the last one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nsclean NIRSpec NSClean algorithm pipeline spec2 pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants