Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin stcal>=1.9.0,<1.10.0 #8808

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Sep 19, 2024

following release of stcal 1.9.0

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API?
    • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@zacharyburnett zacharyburnett added this to the Build 11.1 milestone Sep 19, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review September 19, 2024 19:59
@zacharyburnett zacharyburnett requested a review from a team as a code owner September 19, 2024 19:59
Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@zacharyburnett
Copy link
Collaborator Author

@tapastro
Copy link
Contributor

regtest running at https://github.com/spacetelescope/RegressionTests/actions/runs/10948086861

I expect these to fail, as they require API changes that are still pending some open PRs here. Will merge this once it appears on PyPI.

@tapastro tapastro merged commit 132e4b2 into spacetelescope:master Sep 19, 2024
24 of 25 checks passed
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.75%. Comparing base (5783cfb) to head (61793b0).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8808   +/-   ##
=======================================
  Coverage   61.75%   61.75%           
=======================================
  Files         377      377           
  Lines       38750    38750           
=======================================
  Hits        23931    23931           
  Misses      14819    14819           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett deleted the bump/stcal branch September 20, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants