Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin numpy<2 #8565

Merged
merged 2 commits into from
Jun 17, 2024
Merged

pin numpy<2 #8565

merged 2 commits into from
Jun 17, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 17, 2024

This PR pins numpy to <2.

Numpy 2.0 is now out and several dependencies are not compatible. This run shows failures with numpy 2.0
https://github.com/spacetelescope/jwst/actions/runs/9539549303

From:

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@braingram braingram marked this pull request as ready for review June 17, 2024 13:53
@braingram braingram requested a review from a team as a code owner June 17, 2024 13:53
@braingram braingram changed the title pin numpy pin numpy<2 Jun 17, 2024
@braingram braingram requested a review from jhunkeler June 17, 2024 14:09
@hbushouse hbushouse added this to the Build 11.0 milestone Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.63%. Comparing base (88f5754) to head (dba65ae).
Report is 383 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8565   +/-   ##
=======================================
  Coverage   58.63%   58.63%           
=======================================
  Files         391      391           
  Lines       39081    39081           
=======================================
  Hits        22914    22914           
  Misses      16167    16167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram merged commit 380dc5e into spacetelescope:master Jun 17, 2024
22 checks passed
@braingram braingram deleted the pin_numpy branch June 17, 2024 14:31
braingram added a commit to braingram/jwst that referenced this pull request Jun 18, 2024
This reverts commit 380dc5e, reversing
changes made to a0cdad8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants