remove obsolete EntityUid methods in favor of Entity<T> pattern #5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilonPL
requested review from
metalgearsloth,
PJB3005 and
DrSmugleaf
as code owners
2 tasks
PJB3005
requested changes
Feb 16, 2025
@PJB3005 I think the container ones would be fine to remove? Otherwise the new ones end up getting incorrectly marked as obsolete in new PRs because of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entityuid casts to entity so in 99% of cases it was being marked as obsolete despite being fine
Entity truly is the best thing ever since sliced bread