Fix annotated types in new class expression #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // display_name ClassProcessed | ||
| // signature_documentation java class ClassProcessed<T extends Number> | ||
| // kind Class | ||
| // ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition semanticdb maven . . minimized/ClassProcessed#[T] |
There was a problem hiding this comment.
Note that this bug is caused by a separate issue, and I will fix it separately.
|
|
||
| public ClassProcessed() { | ||
| // ^^^^^^^^^^^^^^ definition semanticdb maven . . minimized/ClassProcessed#`<init>`(). | ||
| // display_name <init> |
There was a problem hiding this comment.
Another bug just spotted 🙃
nope, that's correct
varungandhi-src
approved these changes
Mar 3, 2025
semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbVisitor.java
Outdated
Show resolved
Hide resolved
semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbVisitor.java
Outdated
Show resolved
Hide resolved
antonsviridov-src
deleted the
antonsviridov-graph-1020-npe-in-scip-java-when-using-type-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
new @Bla String()crashed the plugin.Now we handle it explicitly.
Test plan