Fix repo name being Symbol(@@pendingOperation) if repo is local
#7042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, when using Cody in a local repo that's not on the connected instance, this could show up in the prompt: > Codebase context from file tailscale.py in repository Symbol(@@PendingOperation) Problem #1 was that the caller of `getRepoNamesContainingUri` didn't skip the `@@pendingOperation` sentinel value. Problem #2 was that if we didn't find a repository name on the instance, we didn't fall back to the local name. We only did that for dot-com users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, when using Cody in a local repo that's not on the connected instance, this could show up in the prompt:
Problem #1 was that the caller of
getRepoNamesContainingUrididn't skip the@@pendingOperationsentinel value.Problem #2 was that if we didn't find a repository name on the instance, we didn't fall back to the local name. We only did that for dot-com users.
With box fixes it now contains this:
Test plan
const { prompt } = await this.buildPrompt(prompter, chatBuilder, signal, versions.codyAPIVersion)inChatHandler.ts