Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hex] Extract logic functions #1288

Merged
merged 19 commits into from
Dec 2, 2024
Merged

[Hex] Extract logic functions #1288

merged 19 commits into from
Dec 2, 2024

Conversation

sotetsuk
Copy link
Owner

@sotetsuk sotetsuk commented Dec 2, 2024

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.27%. Comparing base (a5c90f1) to head (faecdc0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pgx/hex.py 96.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
- Coverage   80.34%   80.27%   -0.07%     
==========================================
  Files          62       62              
  Lines        5891     5896       +5     
==========================================
  Hits         4733     4733              
- Misses       1158     1163       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sotetsuk sotetsuk merged commit c343851 into main Dec 2, 2024
4 checks passed
@sotetsuk sotetsuk deleted the sotetsuk/hex/extract-fn branch December 2, 2024 06:58
@sotetsuk sotetsuk mentioned this pull request Dec 2, 2024
Open
34 tasks
sotetsuk
sotetsuk commented Dec 3, 2024
View reviewed changes
pgx/hex.py
color = color * ones
can_swap = state.legal_action_mask[-1] * ones
can_swap = (state.step_count == 1) * ones
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line changes the observation in terminated state.
can_swap plane changes from True to False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sotetsuk