Remove Boolector Quantifiers #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 6, 2025 13:56
…k most solvers (now 152 tests run over all solvers compared to 89 before)
…bles for quantifiers
added 4 commits
March 6, 2025 17:29
…sable all tests without assertions or printouts
…che the free vars in the creator as retrieval by name from the solver is not reliable for variables that are also used in quantifiers
|
This PR depends on #447 (due to test changes). |
kfriedberger
requested changes
Mar 6, 2025
kfriedberger
reviewed
Mar 6, 2025
|
Closed in favor of #449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolectors quantifier support never worked in JavaSMT and never will without changing our public API.
The reason is that it needs bound variables, but Boolector does not allow formula manipulation.
Boolector is also in maintenance mode and does not receive any updates.
This PR removes Boolectors quantifiers.