-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onNext allows goTo, stays at current step following return false from callback. Added reflexOnly to force click to continue. #710
Open
IGreatlyDislikeJavascript
wants to merge
11
commits into
sorich87:master
Choose a base branch
from
IGreatlyDislikeJavascript:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 27, 2018
-
Added: New step option "reflexOnly". When step includes "reflexOnly: true" && "reflex: true", tour "Next" button will be hidden for this step and tour can only be continued after the specified reflex element is clicked. onNext and onPrevious obey a FALSE return value from step callback, enabling tour.goTo() and other flow control methods to work correctly in the onNext and onPrevious handler. To use, create a function in the onNext/onPrevious tour steps, and simply return false to prevent the tour from moving to the next step automatically. See sorich87#709 for details.
Configuration menu - View commit details
-
Copy full SHA for 953551f - Browse repository at this point
Copy the full SHA 953551fView commit details -
Allow step.element to use function
Step "element" can now use a function to dynamically select the DOM element for the step. Usage: element: function() { return $(document.body).find(".my-dynamic-element"); }, title: "Dynamic!", content: "This element was found by jquery", Change to Tour.prototype.getStep = function (i)
Configuration menu - View commit details
-
Copy full SHA for 4242065 - Browse repository at this point
Copy the full SHA 4242065View commit details
Commits on Nov 28, 2018
-
Init fixed. Scroll improved. onElementUnavailable added. Progress bar…
… added Fixed flow issue with tour.init() especially where page contains hidden elements - Do not call tour.init(). Create your new Tour({options}); then call Tour.start or .restart when you want to show the tour. (sorich87#700 Fixed inefficient display of tour popover - popovers do not constantly reload current step on scroll. Flickering/flashing resolved. (sorich87#685) - element popovers don't move around the page as you scroll - this is a personal thing, but I didn't like the functionality where if you scroll the page so the element is no longer visible, the popover follows you around. Doesn't make much sense because the popover isn't visually attached to it's parent element. - orphan popovers stay stuck to the center of the screen no matter what Added onElementUnavailable(tour, step) to global and step options - Specify a function as normal (i.e.: same as onNext etc) with pattern above. Function will be called when the element of the step is unavailable == missing, hidden etc. "step" parameter indicates the step that is going to be skipped. Added progress indicators and ability to dynamically change during tour: - Global option "showProgressBar" : set to true to show a (bootstrap) progress bar, or false to hide it - Step option "showProgressBar" will override global option, so you can turn on/off progress bars per step Customise the progress bar using option getProgressBarHTML: getProgressBarHTML: function(percentProgress) { return '<div class="progress"><div class="progress-bar progress-bar-striped" role="progressbar" style="width: ' + percentProgress + '%;"></div></div>'} - Global and step option "showProgressText" shows a "N / X" tour step counter in the popover title bar Customise the text using option getProgressTextHTML: getProgressBarHTML: function(stepNumber, percentProgress, stepCount) { return '<span class="pull-right">' + stepNumber + '/' + stepCount + '</span>'; } Based on sorich87#362
Configuration menu - View commit details
-
Copy full SHA for 38440a9 - Browse repository at this point
Copy the full SHA 38440a9View commit details -
Bug in the last upload, uploaded wrong ver. tour.start() would never continue, now fixed.
Configuration menu - View commit details
-
Copy full SHA for b04b28f - Browse repository at this point
Copy the full SHA b04b28fView commit details
Commits on Nov 29, 2018
-
Tour didn't start due to setCurrentStep returning null instead of first step if nothing was set in localstorage.
Configuration menu - View commit details
-
Copy full SHA for 7fbdc18 - Browse repository at this point
Copy the full SHA 7fbdc18View commit details -
Configuration menu - View commit details
-
Copy full SHA for be63340 - Browse repository at this point
Copy the full SHA be63340View commit details
Commits on Dec 1, 2018
-
Full list of all features added below. Review comments in top of bootstrap-tour.js for full explanation and examples: 1. onNext/onPrevious - prevent auto-move to next step, allow .goTo 2. *** Do not call Tour.init *** - fixed tours with hidden elements on page reload 3. Dynamically determine step element by function 4. Only continue tour when reflex element is clicked using reflexOnly 5. Call onElementUnavailable if step element is missing 6. Scroll flicker/continual step reload fixed 7. Magic progress bar and progress text, plus options to customize per step 8. Prevent user interaction with element using preventInteraction 9. Wait for arbitrary DOM element to be visible before showing tour step/crapping out due to missing element, using delayOnElement 10. Handle bootstrap modal dialogs better - autodetect modals or children of modals, and call onModalHidden when user dismisses modal without following tour steps 11. Automagically fixes drawing issues with Bootstrap Selectpicker (https://github.com/snapappointments/bootstrap-select/)
Configuration menu - View commit details
-
Copy full SHA for 8cac06e - Browse repository at this point
Copy the full SHA 8cac06eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8315532 - Browse repository at this point
Copy the full SHA 8315532View commit details
Commits on Dec 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9351047 - Browse repository at this point
Copy the full SHA 9351047View commit details
Commits on Dec 12, 2018
-
READ COMMENT AT TOP OF JS FOR ALL DETAILS * Changes from 0.5: * - Added "unfix" for bootstrap selectpicker to revert zindex after step that includes this plugin * - Fixed issue with Bootstrap dialogs. Handling of dialogs is now robust * - Fixed issue with BootstrapDialog plugin: https://nakupanda.github.io/bootstrap3-dialog/ . See notes below for help. * - Improved the background overlay and scroll handling, unnecessary work removed
Configuration menu - View commit details
-
Copy full SHA for aede5d7 - Browse repository at this point
Copy the full SHA aede5d7View commit details
Commits on Feb 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b9261c7 - Browse repository at this point
Copy the full SHA b9261c7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.