Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete permission for AdminType #8200

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

DenuxPlays
Copy link
Contributor

@DenuxPlays DenuxPlays commented Aug 13, 2024

Subject

This pr fixes the bug that delete on an item cannot be voted on with a subject.

I am targeting this branch, because it's a non-breaking bug-fix.

Closes NaN

Changelog

### Fixed
- Allow delete permission to be voted on a specific subject.

- Now the `delete` attribute can be voted on wit a specific subject
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the delay.

I'm surprised nobody got an issue before with this.

@VincentLanglet VincentLanglet merged commit 67b39f0 into sonata-project:4.x Nov 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants