Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add createDynamic utility. #2422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DaniGuardiola
Copy link

Summary

Dynamic is very helpful for polymorphism use-cases. However, in libraries, there's a potential optimization to be leveraged by not performing a prop split, and leaving that detail to the library author.

For this purpose, I've extracted most of the logic in Dynamic into a createDynamic utility (now used by Dynamic under the hood.

In my case (Ariakit Solid), due to how things are laid out, I can effectively fulfill this API without splitting, which wouldn't be doable with Dynamic alone.

How did you test this change?

TODO

Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: baf426c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant