Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dynamic
is very helpful for polymorphism use-cases. However, in libraries, there's a potential optimization to be leveraged by not performing a prop split, and leaving that detail to the library author.For this purpose, I've extracted most of the logic in
Dynamic
into acreateDynamic
utility (now used byDynamic
under the hood.In my case (Ariakit Solid), due to how things are laid out, I can effectively fulfill this API without splitting, which wouldn't be doable with
Dynamic
alone.How did you test this change?
TODO