Psi selector #1
Open
Psi selector #1
+1,155
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 8, 2021 22:27
… min value for bin
|
Sorry, github didn't send me a notification about this :_( So I didn't see it. |
added 14 commits
September 29, 2021 20:28
[MRG] final edits to the class
solegalli
added a commit
that referenced
this pull request
Sep 4, 2024
* docs: Adds link to docs in readme (#1) Would resolve feature-engine#680 if merged * fix typo * rebase and add changes in changelog * add missing bracket --------- Co-authored-by: Darigov Research <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I have here a first version of the code for dropping features with high PSI. I still need to polish the code and work on the documentation but I believe it would be great if you can have a first look at it.
I am also wondering if you use tools like black and mypy to perform automated check. This would ensure my code has a similar layout uses the same coding rules as you do.