Register viewSyntaxTree conditionally depending of server capability
#77
+128
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotmag769
requested review from
mkaput and
integraledelebesgue
and removed request for
a team
piotmag769
changed the title
viewSyntaxTree conditionally depending of server capability
piotmag769
force-pushed
the
conditional-view-syntax-tree
branch
from
e102bec to
7382e50
Compare
piotmag769
commented
Feb 7, 2025
Comment on lines
+200
to
+213
| ctx.extension.subscriptions.push( | ||
| client.onRequest(lsp.RegistrationRequest.type, ({ registrations }) => { | ||
| for (const reg of registrations) { | ||
| if (reg.method === "custom/ViewSyntaxTree") { | ||
| vscode.commands.executeCommand( | ||
| "setContext", | ||
| "cairo1.viewSyntaxTreeCommandAvailable", | ||
| true, | ||
| ); | ||
| registerViewSyntaxTreeProvider(client, ctx); | ||
| } | ||
| } | ||
| }), | ||
| ); |
There was a problem hiding this comment.
This is the relevant part, the rest is just a fix of disposables that were forgotten to push to subscriptions
piotmag769
force-pushed
the
conditional-view-syntax-tree
branch
from
904db71 to
90c9528
Compare
piotmag769
force-pushed
the
conditional-view-syntax-tree
branch
from
90c9528 to
4d99392
Compare
|
Closing in favour of PR stack starting #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.